Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random.int added #773

Merged
merged 15 commits into from
Dec 30, 2024
Merged

Random.int added #773

merged 15 commits into from
Dec 30, 2024

Conversation

chase1k
Copy link
Collaborator

@chase1k chase1k commented May 12, 2024

What type of PR is this?

/kind documentation
/kind feature
/kind eldritch-function

What this PR does / why we need it:

Adds random.int function to generate a secure random int

Which issue(s) this PR fixes:

Fixes #759

@chase1k chase1k requested a review from Cictrone May 12, 2024 00:12
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

hulto
hulto previously approved these changes May 12, 2024
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass

implants/lib/eldritch/src/random/int_impl.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm besides typo! id maybe widen your tests bounds a little just to make the test less flaky however. either that or increase the number of iterations.

docs/_docs/user-guide/eldritch.md Outdated Show resolved Hide resolved
@chase1k chase1k self-assigned this Jul 5, 2024
jabbate19
jabbate19 previously approved these changes Nov 5, 2024
@jabbate19 jabbate19 requested a review from Cictrone December 28, 2024 23:59
hulto
hulto previously approved these changes Dec 29, 2024
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chase1k chase1k merged commit e72e334 into main Dec 30, 2024
6 checks passed
@chase1k chase1k deleted the 759-feature-implement-randomint-function branch December 30, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implement random.int function
4 participants