Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraphQL Mutation to Create Credentials for Host #808

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jabbate19
Copy link
Collaborator

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

If we have external tools that can provide us credentials, there is currently no easy way for those to be inserted.

  • Credentials no longer require a Task.
  • Credentials can be created via mutation

Which issue(s) this PR fixes:

:shipit:

@jabbate19 jabbate19 force-pushed the graphql-create-credential branch from 7de2327 to cd53dac Compare December 28, 2024 18:44
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to:

  • Implement generated the generated mutation resolver method in tavern/internal/graphql/mutation.resolvers.go ?
  • write a unit test for your new mutation by defining YAML test cases in a new

@jabbate19
Copy link
Collaborator Author

Do you need to:

  • Implement generated the generated mutation resolver method in tavern/internal/graphql/mutation.resolvers.go ?
  • write a unit test for your new mutation by defining YAML test cases in a new

@hulto Fixed!

tavern/config.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants