Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove imp dependency #69

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Remove imp dependency #69

merged 1 commit into from
Mar 11, 2024

Conversation

Rogdham
Copy link
Contributor

@Rogdham Rogdham commented Mar 9, 2024

Python 3.12 dropped the module imp.

The code is changed according to https://docs.python.org/3/whatsnew/3.12.html#imp and a test case is added.

Fixes #64.

@Rogdham
Copy link
Contributor Author

Rogdham commented Mar 9, 2024

Paging @tomhughes and @a-detiste that may be interested 😉

Copy link
Collaborator

@langston-barrett langston-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@langston-barrett langston-barrett enabled auto-merge (rebase) March 11, 2024 19:34
@langston-barrett langston-barrett merged commit 79cfb42 into sphinx-contrib:master Mar 11, 2024
5 checks passed
@Rogdham Rogdham deleted the remove-imp branch March 11, 2024 19:40
@Rogdham
Copy link
Contributor Author

Rogdham commented Mar 11, 2024

Thank you! 🎉

It is my understanding that the project now works with Python 3.12!

@a-detiste
Copy link
Contributor

Time for a release ?

@langston-barrett
Copy link
Collaborator

I'm happy to push a release as soon as we test against Python 3.12 and note the compatibility in setup.py, see #70. PRs welcome!

@a-detiste
Copy link
Contributor

uploaded to Debian as 0.1.8-2

@langston-barrett
Copy link
Collaborator

@a-detiste Also released as version 0.1.9, see https://pypi.org/project/sphinxcontrib-autoprogram/#history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 has dropped the imp module
3 participants