fix(pipelineTriggers): change buildNumber type from int to string #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmcintosh
approved these changes
Nov 17, 2022
| @@ -64,7 +64,7 @@ trait RetrofitStubs { | |||
| } | |||
|
|
|||
| BuildEvent createBuildEventWith(BuildEvent.Result result) { | |||
| def build = result ? new BuildEvent.Build(result == BUILDING, 1, result, null, []) : null | |||
| def build = result ? new BuildEvent.Build(result == BUILDING, '1', result, null, []) : null | |||
There was a problem hiding this comment.
SUPER minor, but what about adding a test for a non-numeric build number as well as a numeric build number? :P And maybe a call out/comment on why? I like this overall though!
in order to support build numbers which are not strict integers (i.e. "123.1")
jaredstehler
force-pushed
the
build-number-tostring
branch
from
eb83cd5 to
dba230c
Compare
|
can this be merged yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to support build numbers which are not strict integers (i.e. "123.1")
spinnaker/spinnaker#6743