feat(pipeline): add a pipelineNameFilter query param to the /pipelines/{application} endpoint #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We prefer that non-test backend code be written in Java or Kotlin, rather than Groovy. The following files have been added and written in Groovy:
See our server-side conventions here. |
kirangodishala
pushed a commit
to kirangodishala/gate
that referenced
this pull request
Oct 15, 2024
…figs endpoint This plumbs through the new pipelineNameFilter query param to the front50 service call in gate. Refer the front50 change: spinnaker/front50#1504
kirangodishala
force-pushed
the
pipeline-name-filter-query-param
branch
from
c96b7f1 to
3f06b13
Compare
kirangodishala
pushed a commit
to kirangodishala/gate
that referenced
this pull request
Oct 16, 2024
…figs endpoint This plumbs through the new pipelineNameFilter query param to the front50 service call in gate. Refer the front50 change: spinnaker/front50#1504
dbyron-sf
reviewed
Nov 5, 2024
front50-test/src/main/groovy/com/netflix/spinnaker/front50/pipeline/PipelineDAOSpec.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Nov 5, 2024
front50-core/src/test/java/com/netflix/spinnaker/front50/pipeline/DefaultPipelineDAOTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Nov 5, 2024
front50-core/src/test/java/com/netflix/spinnaker/front50/pipeline/DefaultPipelineDAOTest.java
Show resolved
Hide resolved
dbyron-sf
reviewed
Nov 5, 2024
...st/src/main/java/com/netflix/spinnaker/front50/pipeline/SqlPipelineDAOTestConfiguration.java
Outdated
Show resolved
Hide resolved
… /pipelines/{application} endpoint
This adds a pipelineNameFilter query parameter to the /pipelines/{application} endpoint. If pipelineNameFilter is present, the endpoint will return a list of pipelines whose pipeline name contains the pipelineNameFilter.
This change is necessary to enable some optimizations in the front end - namely, filtering pipelines on the backend, instead of always querying for every pipeline in an application, and filtering the list in the front end.
…on implementation.
kirangodishala
force-pushed
the
pipeline-name-filter-query-param
branch
from
d076e91 to
c4885dc
Compare
kirangodishala
pushed a commit
to kirangodishala/gate
that referenced
this pull request
Nov 6, 2024
…figs endpoint This plumbs through the new pipelineNameFilter query param to the front50 service call in gate. Refer the front50 change: spinnaker/front50#1504
dbyron-sf
approved these changes
Nov 6, 2024
mergify bot
pushed a commit
to spinnaker/gate
that referenced
this pull request
Nov 6, 2024
…figs endpoint (#1839) This plumbs through the new pipelineNameFilter query param to the front50 service call in gate. Refer the front50 change: spinnaker/front50#1504 Co-authored-by: Richard Timpson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pipelineNameFilter query parameter to the /pipelines/{application} endpoint. If pipelineNameFilter is present, the endpoint will return a list of pipelines whose pipeline name contains the pipelineNameFilter.
This change is necessary to enable some optimizations - namely, filtering pipelines on the backend, instead of always querying for every pipeline in an application, and filtering the list in the front end.