feat(web): Exclude Disabled pipelines query parameter #1520
+55
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // pipeline.getDisabled may be null, so check that before comparing. If | ||
| // pipeline.getDisabled is null, the pipeline is enabled. | ||
| boolean pipelineEnabled = | ||
| (pipeline.getDisabled() == null) || (pipeline.getDisabled() == false); |
There was a problem hiding this comment.
NIT: MIght use the Optional stuff here :)
dbyron-sf
reviewed
Dec 19, 2024
| @RequestParam(required = false, value = "refresh", defaultValue = "true") boolean refresh) { | ||
| @RequestParam(required = false, value = "refresh", defaultValue = "true") boolean refresh, | ||
| @RequestParam(required = false, value = "enabledPipelines", defaultValue = "false") | ||
| Boolean enabledPipelines) { |
There was a problem hiding this comment.
Pretty sure this can be lower-case-b boolean since there's a default.
Suggested change
| Boolean enabledPipelines) { | |
| boolean enabledPipelines) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally exclude the Disabled pipelines of an application. This can be opt-in by the Orca PR spinnaker/orca#4819