Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(output): send info strings to stderr #350

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

webmakersteve
Copy link
Contributor

Currently the tool sends out informational output to stdout. This makes it hard to pipe output into tools like jq and such.

Adjusts it so only jsonoutput and output go to stdout and the rest should go to stderr via warn.

@webmakersteve
Copy link
Contributor Author

This is technically a breaking change if people depend on the old behavior - so could use some advice on if this is something desired by the team. And if so, how to indicate that in the pr.

@webmakersteve
Copy link
Contributor Author

Anyone available to review this? if it isn't desired it can be closed.

@karlskewes
Copy link
Contributor

Thank you for investigating and raising a PR with the potential change.

Is the quiet flag insufficient?

$ spin | grep quiet
  -q, --quiet                    squelch non-essential output

I don't have a Spinnaker setup at the moment to query with spin, but from memory using --quiet would trim non-JSON output enabling jq or redirect to file usage. I could be mistaken or perhaps it wasn't for all commands..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants