Added uploadTypedRows to BigQuery client #5218
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5218 +/- ##
==========================================
- Coverage 62.63% 62.53% -0.10%
==========================================
Files 301 301
Lines 10845 10867 +22
Branches 768 744 -24
==========================================
+ Hits 6793 6796 +3
- Misses 4052 4071 +19 ☔ View full report in Codecov by Sentry. |
build.sbt
Outdated
| @@ -83,7 +83,7 @@ val googleCloudDatastoreVersion = "0.108.6" | |||
| val googleCloudMonitoringVersion = "3.32.0" | |||
| val googleCloudPubSubVersion = "1.107.13" | |||
| val googleCloudSpannerVersion = "6.55.0" | |||
| val googleCloudStorageVersion = "2.30.1" | |||
| val googleCloudStorageVersion = "2.26.0" | |||
There was a problem hiding this comment.
Your link points to GCP libraries-bom 26.22.0 but beam 2.53 uses 26.28.0 here.
There was a problem hiding this comment.
Right, reverting this
scio-google-cloud-platform/src/main/scala/com/spotify/scio/bigquery/client/LoadOps.scala
Show resolved
Hide resolved
| def uploadTypedRows[T <: HasAnnotation: TypeTag]( | ||
| tableSpec: String, | ||
| rows: List[T], | ||
| tempLocation: String, |
There was a problem hiding this comment.
Since this is temp, shouldn't we clean if afterward ?
There was a problem hiding this comment.
I was thinking about bucket retention policy, but yeah, deleting it would be more optimal
There was a problem hiding this comment.
on the other hand if I do:
avro(
List(blobId.toGsUtilUri),
tableSpec,
schema = Some(bqt.schema),
createDisposition = createDisposition,
writeDisposition = writeDisposition
)
storage.delete(blobId)
I am not confident that avro is fully synchronous and BQ doesn't read that file on the background
There was a problem hiding this comment.
execute contains jobService.waitForJobs(loadJob) so I think this is fine.
I'm wondering also if we should create a SaveOps to allow saving some file formats (avro/json)
| * Upload List of rows to Cloud Storage as Avro file and load to BigQuery table. Note that element | ||
| * type `T` must be annotated with [[BigQueryType]]. | ||
| */ | ||
| def uploadTypedRows[T <: HasAnnotation: TypeTag]( |
There was a problem hiding this comment.
IMHO this naming can be simplified. Other APIs here do not have the upload prefix.
Usage will be from BigQuery with bq.load.uploadTypeRows.
I think this should be named
| def uploadTypedRows[T <: HasAnnotation: TypeTag]( | |
| def typedRows[T <: HasAnnotation: TypeTag]( |
writeTypedRowsis not always suitable. It is using GCP'sinsertAll. Some GCP APIs do not reflect recent loads this way, like:table.getNumRows()returns 0Old post.
Data loaded as upload from file does not cause the same problem.