Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jacob/create client #182

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Jacob/create client #182

wants to merge 18 commits into from

Conversation

jacobprall
Copy link
Member

Description of change

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@jacobprall jacobprall requested a review from Gioee December 23, 2024 18:27
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 26, 2024
View reviewed changes
src/packages/test/client.test.ts
it('should throw errors if no valid params are provided', () => {
expect(() => new SQLiteCloudClient('')).toThrow()
expect(() => new SQLiteCloudClient({ connectionString: '' })).toThrow()
expect(() => new SQLiteCloudClient({ connectionString: 'invalid' })).toThrow()

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical test

The hard-coded value "invalid" is used as
authorization header
Loading
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gioee Gioee Awaiting requested review from Gioee

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jacobprall