Fix bug - case-sensitive channel name handling #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to fix the issue described in squidowl#494
|
Thanks for this PR! However I feel like this is going to be addressed by @andymandias in #668. |
|
No worries! I had seen that they had self-assigned working on it in the issue page, I just wasn't sure at the time how far down the road a fix was going to be before implementation. Since this bug was the only thing preventing me from being able to switch over to halloy as my daily driver and I was enjoying the client overall, I figured I may as well have a go at it so that I can use it in the meantime and have a little look at rust in the process, once it was working I thought I should share it incase somebody else was in the same boat while the full fix was on its way :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix the issue described in #494 where unneeded case-sensitivity in handling channel names causes people's messages to not be displayed if those people joined a channel using different capitalisation than you (on servers that do not normalise case).
IRC standard specifies case-insensitive channel names per RFC 2812.
Apologies if the way I've changed it isn't great or introduces another bug that I did not find testing this, I am not fluent in rust.