allow non ascii characters in compiled prompts #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenmoneygithub
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks for the PR!
Can we use a try-except block instead of introducing a new arg? IIUC the loading should always work, only saving could cause issue on ascii-only platform. In general we are cautious at introducing new args to public APIs, the longer the arglist, the more confusing it becomes.
|
Just so I understand. Do you want to allow ensure_ascii=False? Should we just make it False by default? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional ensure_ascii parameter to saving a module, which is consistent with json.dumps declarations.
closes #1911