Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update blas/ext/base/sdsnansum to follow current project conventions #1773

Merged
merged 19 commits into from
Apr 14, 2024

Conversation

alextes90
Copy link
Contributor

@alextes90 alextes90 commented Mar 8, 2024

Resolves #1523 .

Description

What is the purpose of this pull request?

This pull request:

  • refactors blas/ext/base/sdsnansum to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Planeshifter Planeshifter changed the title refactor: update blas/ext/base/sdsnansum to follow current project conventions refactor: update blas/ext/base/sdsnansum to follow current project conventions Mar 8, 2024
@kgryte kgryte added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. labels Mar 11, 2024
@alextes90
Copy link
Contributor Author

Fix all errors

@alextes90
Copy link
Contributor Author

Forth attempt)

@alextes90
Copy link
Contributor Author

I make the change but I am not sure where the problem come from and why the system failed to build addon.
Can you help with it?

@kgryte
Copy link
Member

kgryte commented Apr 7, 2024

@alextes90 Looks like the addon is successfully building now. Seems you were just missing dependencies in the manifest.json file.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good now. Will merge after CI checks have passed; I only restored the original copyright years in a bunch of files (we don't change them for existing files) and updated how the random numbers are generated to mirror how we have done it in a bunch of the other blas/ext/base/*nan* packages. Thanks @alextes90!

@Planeshifter Planeshifter merged commit c6703d9 into stdlib-js:develop Apr 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Needs Review A pull request which needs code review.
Projects
None yet
4 participants