-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update blas/ext/base/sdsnansum
to follow current project conventions
#1773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
blas/ext/base/sdsnansum
to follow current project conventions
lib/node_modules/@stdlib/blas/ext/base/sdsnansum/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sdsnansum/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sdsnansum/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
Fix all errors |
Forth attempt) |
I make the change but I am not sure where the problem come from and why the system failed to build addon. |
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/blas/ext/base/sdsnansum/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
@alextes90 Looks like the addon is successfully building now. Seems you were just missing dependencies in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good now. Will merge after CI checks have passed; I only restored the original copyright years in a bunch of files (we don't change them for existing files) and updated how the random numbers are generated to mirror how we have done it in a bunch of the other blas/ext/base/*nan*
packages. Thanks @alextes90!
Resolves #1523 .
Description
This pull request:
Related Issues
This pull request:
blas/ext/base/sdsnansum
to follow current project conventions #1523Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers