Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update math/base/assert/int32-is-even to follow latest project conventions #4601

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

refactor: update math/base/assert/int32-is-even to follow latest project conventions #4601

wants to merge 7 commits into from
+44 −69

Conversation

vivekmaurya001
Copy link
Contributor

Resolves None.

Description

  • refactoring addon.c to follow latest project conventions for math/base/assert/int32-is-even
  • updating benchmark calculations

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@vivekmaurya001
refactor: update math/base/assert/int32-is-even to follow latest proj…
32d1354 
…ect conventions

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@vivekmaurya001
Merge branch 'int32-is-even' of https://github.com/vivekmaurya001/stdlib
cdfaf34 
 into int32-is-even

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jan 6, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 6, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/assert/int32-is-even $\color{green}149/149$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}149/149$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001
Copy link
Contributor Author

good afternoon , @kgryte please give this a reveiw

vivekmaurya001
vivekmaurya001 commented Jan 8, 2025
View reviewed changes
lib/node_modules/@stdlib/math/base/assert/int32-is-even/benchmark/benchmark.js
b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*1.0e7 ) - 5.0e6;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the number that's get generated here is not getting round , is it a mistake or intentional ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely a mistake. Feel free to fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh sorry i realised that i have been using a extra package float64toInt32 rather than using opts in discreteuniform

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have corrected it

@vivekmaurya001 vivekmaurya001 marked this pull request as draft January 8, 2025 12:29
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 8, 2025
vivekmaurya001 and others added 5 commits January 8, 2025 12:59
@vivekmaurya001
refactor: update math/base/assert/int32-is-even to follow latest proj…
0e9c8e9 
…ect conventions

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@vivekmaurya001
Merge branch 'stdlib-js:develop' into int32-is-even
b5c0d0b
@vivekmaurya001
Merge branch 'stdlib-js:develop' into int32-is-even
e7fcf03 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---
@vivekmaurya001
refactor: update math/base/assert/int32-is-even to follow latest proj…
90e3302 
…ect conventions
@vivekmaurya001
Merge branch 'int32-is-even' of https://github.com/vivekmaurya001/stdlib
3c4ee55 
 into int32-is-even

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@vivekmaurya001
Copy link
Contributor Author

im not able to get where error is occuring

@vivekmaurya001 vivekmaurya001 marked this pull request as ready for review January 8, 2025 13:24
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivekmaurya001 @stdlib-bot @kgryte