Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. add configure proxyUrl #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imiskolee
Copy link

User Story

current, a lot of users has access issue on private file upload, succeed upload but fail access(blocked by ACL rule),
so I am designing the proxyUrl to replace google cloud storage domain, and using another proxy program to access private files https://github.com/daichirata/gcsproxy

@Lith
Copy link
Collaborator

Lith commented Apr 8, 2022

Hello @imiskolee,

Thanks for your contribution !
Before accept this PR could you sign-off your commit (DCO) ?
Just follow instruction here : https://github.com/strapi-community/strapi-provider-upload-google-cloud-storage/pull/124/checks?check_run_id=5528273964

This seems to be good enough for me :)

Thx

@Lith Lith self-assigned this Apr 8, 2022
@Lith Lith added the enhancement New feature or request label Apr 8, 2022
Copy link
Collaborator

@Lith Lith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check and fix all warning about code guidelines (missing spaces, simple quote instead double quote...etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants