Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated implementation for better type info #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WesleyClements
Copy link

The current implementation doesn't allow for TypeScript to figure out that Counter extends Transform.
Unfortunately this can't be resolved by simply adding a declaration file since Counter can be called with or without new.
The simplest way I could come up with while changing as little as possible was to refactor the code to use the class syntax.
This unfortunately is a breaking change which results in any code that didn't use new breaking.
As such I have incremented the major version to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant