Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unset version when building locally #365

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Fix unset version when building locally #365

merged 6 commits into from
Feb 8, 2024

Conversation

blinktag
Copy link
Member

Fix for #363

  • Update go.mod and to rename package to github.com/streamdal/plumber so that build time version injection works
  • Update CI process to populate version.txt with the version tag and short SHA so that running make build locally will inject the correct version and sha

@blinktag blinktag requested a review from dselans January 25, 2024 19:18
@blinktag blinktag requested a review from fritzstauff February 8, 2024 14:17
fritzstauff
fritzstauff approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@fritzstauff fritzstauff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blinktag blinktag merged commit 04acb41 into master Feb 8, 2024
2 checks passed
@blinktag blinktag deleted the blinktag/fix_version_tag branch February 8, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzstauff fritzstauff fritzstauff approved these changes

@dselans dselans Awaiting requested review from dselans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blinktag @fritzstauff