Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dselans/streamdal integration #369

Merged
merged 9 commits into from
Mar 14, 2024
Merged

Conversation

dselans
Copy link
Contributor

@dselans dselans commented Mar 14, 2024

DO NOT MERGE UNTIL GO-SDK PR IS MERGED AND A NEW SDK RELEASE IS MADE

streamdal/streamdal#295

This integrates streamdal's Go SDK into Kafka and GCP-PubSub.

You enable it by passing a few streamdal flags via manage:

plumber manage create relay kafka \
  --connection-id 3bfd8126-a32f-43ed-a89d-94e616d9b7ea \
  --use-consumer-group \
  --topics test \
  --collection-token 3831a9fb-4117-4599-b834-04d47341b491 \
  --streamdal-integration-enable \
  --streamdal-integration-service-name plumber

The SDK is instantiated per relay.

Tested it w/ Kafka.

I had to update vendor because SDK introduced a bunch of new libs - I tested relay create/delete/stop/resume - everything seems to work right.

@dselans dselans requested a review from blinktag March 14, 2024 05:35
@dselans dselans merged commit a527691 into master Mar 14, 2024
2 checks passed
@dselans dselans deleted the dselans/streamdal-integration branch March 14, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants