fix(core): fix patch method when applying on multiple resource kinds (#…

…493) fix: #493
streamthoughts · Oct 17, 2024 · a8903fa · a8903fa
1 parent bab36ae
commit a8903fa
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 16 deletions.
diff --git a/core/src/main/java/io/streamthoughts/jikkou/core/DefaultApi.java b/core/src/main/java/io/streamthoughts/jikkou/core/DefaultApi.java
@@ -423,7 +423,7 @@ public ApiChangeResultList patch(@NotNull List<ResourceChange> changes,
                 context.isDryRun()
             );
             Reconciler<HasMetadata, ResourceChange> reconciler = new Reconciler<>(controller);
-            List<ChangeResult> results = reconciler.apply(changes, mode, context);
+            List<ChangeResult> results = reconciler.apply(items, mode, context);
             changeResults.addAll(results);
             LOG.info("Executed {} changes for group={}, apiVersion={} and kind={} using controller: '{}' (mode: {}, dryRun: {}).",
                 results.size(),

diff --git a/core/src/main/java/io/streamthoughts/jikkou/core/models/ApiChangeResultList.java b/core/src/main/java/io/streamthoughts/jikkou/core/models/ApiChangeResultList.java
@@ -13,8 +13,6 @@
 import io.streamthoughts.jikkou.core.annotation.Kind;
 import io.streamthoughts.jikkou.core.annotation.Reflectable;
 import io.streamthoughts.jikkou.core.reconciler.ChangeResult;
-import java.beans.ConstructorProperties;
-import java.util.Collections;
 import java.util.List;
 import java.util.Optional;
 
@@ -41,19 +39,6 @@ public record ApiChangeResultList(@JsonProperty("kind") String kind,
     public static final String KIND = "ApiChangeResultList";
     public static final String API_VERSION = "core.jikkou.io/v1";
 
-    /**
-     * Creates a new {@link ApiChangeResultList} instance.
-     */
-    @ConstructorProperties({
-            "kind",
-            "apiVersion",
-            "metadata",
-            "dryRun",
-            "results"
-    })
-    public ApiChangeResultList {
-        results = Collections.unmodifiableList(results);
-    }
 
     /**
      * Creates a new {@link ApiChangeResultList} instance.