refactor: use %q and %T to simplify fmt.Sprintf #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
force-pushed
the
refactor/simplify-with-sprintf-q
branch
from
9783d40 to
d57bac8
Compare
ccoVeille
approved these changes
Nov 24, 2024
HaraldNordgren
approved these changes
Dec 6, 2024
dolmen
requested changes
Dec 10, 2024
alexandear
changed the title
alexandear
force-pushed
the
refactor/simplify-with-sprintf-q
branch
2 times, most recently
from
da3dc7c to
8e9d214
Compare
Co-authored-by: Olivier Mengué <[email protected]>
alexandear
force-pushed
the
refactor/simplify-with-sprintf-q
branch
from
8e9d214 to
30f3cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR simplifies strings inside
fmt.Sprintfstatements.Changes
Replace
"\"%s\""with%q.Replace
fmt.Sprintf("\"%s"\", reflect.TypeOf(t))withfmt.Sprintf("%T", t).Motivation
%qhas fewer symbols than"\"%s\""but means the same for strings. See https://pkg.go.dev/fmt#hdr-Printing:%Tis also shorter thanreflect.TypeOf.