Improve version check #1195
Improve version check #1195
Conversation
Improves version check by making following changes: 1. Look for version in Submariner.Status and ServiceDiscovery.Spec. These two are populated by submariner-oprator so are always present and accurate. This also fixes a bug in current code where if Submariner.Spec.Version is missing, it doesn't check for it in Status or ServiceDiscovery. 2. For subctl commands the major and minor versions are more important than patch versions. This is because changes that significantly affect subctl commands are mostly done in releases with subsequent releases being mostly bug fixes. Signed-off-by: Vishal Thapar <[email protected]>
vthapar
requested review from
Jaanki,
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr1195/vthapar/improve-version-check |
|
@maayanf24 Draft of the changes I had. Needs more testing, but should work. Would be good to discuss the design changes with team, or in an EP. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
🤖 Closed branches: [z_pr1195/vthapar/improve-version-check] |
Improves version check by making following changes:
Look for version in Submariner.Status and ServiceDiscovery.Spec. These two are populated by submariner-oprator so are always present and accurate. This also fixes a bug in current code where if Submariner.Spec.Version is missing, it doesn't check for it in Status or ServiceDiscovery.
For subctl commands the major and minor versions are more important than patch versions. This is because changes that significantly affect subctl commands are mostly done in releases with subsequent releases being mostly bug fixes.