Use cobra's version flag support #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigning a value to the Version field in the root cobra command automatically defines a --version flag which displays the command name and version, in much the same way as "subctl version" does already. This provides version information in a fashion aligned with common practice. Signed-off-by: Stephen Kitt <[email protected]>
skitt
requested review from
Jaanki,
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr1229/skitt/cobra-version-flag |
dfarrell07
approved these changes
Sep 23, 2024
|
Should we remove our version command? |
vthapar
approved these changes
Sep 23, 2024
There might be automated scripts using it. We should deprecate it before removing it. |
|
🤖 Closed branches: [z_pr1229/skitt/cobra-version-flag] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigning a value to the Version field in the root cobra command automatically defines a --version flag which displays the command name and version, in much the same way as "subctl version" does already. This provides version information in a fashion aligned with common practice.