Output init containers in subctl gather #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Jaanki,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1267/tpantelis/gather_init_container |
Refactored "gatherPodLogs" to take the desired container names. If none specified, gather logs for all init and normal containers confgiured in the pod. Also, if a pod fails, it's useful to see the pod details so gather the YAML for pod resources for daemonsets and deployments. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
gather_init_container
branch
from
c1d11cb to
037b0be
Compare
tpantelis
added
the
backport
vthapar
approved these changes
Nov 22, 2024
4 tasks
|
@tpantelis Backport this for 0.18? |
yes |
dfarrell07
approved these changes
Nov 25, 2024
|
🤖 Closed branches: [z_pr1267/tpantelis/gather_init_container] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
gatherPodLogsto take the desired container names. If none specified, gather logs for all init and normal containers confgiured in the pod.Also, if a pod fails, it's useful to see the pod details so gather the YAML for pod resources for daemonsets and deployments.
Fixes #1266