Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Submariner dependencies to v0.20.0-m2 #1283

Closed
wants to merge 2 commits into from
Closed

Update Submariner dependencies to v0.20.0-m2 #1283

wants to merge 2 commits into from

Conversation

submariner-bot
Copy link
Contributor

Update Submariner dependencies to v0.20.0-m2

@submariner-bot
Copy link
Contributor Author

🤖 I see this PR is using the local branch workflow, ignoring it on my side, have fun!
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jan 2, 2025
@submariner-bot submariner-bot enabled auto-merge (rebase) January 2, 2025 17:34
@submariner-bot submariner-bot mentioned this pull request Jan 2, 2025
Merged
@skitt
Copy link
Member

skitt commented Jan 2, 2025

#1282 addresses the linting error.

@tpantelis
Copy link
Contributor

tpantelis commented Jan 2, 2025 •
edited
Loading

The subctl diagnose system test fails due to submariner-metrics-proxy pod failing. Here's the pod log:

Ncat: Version 7.92 ( https://nmap.org/ncat )
Ncat: Listening on :::8081
Ncat: Listening on 0.0.0.0:8081
Ncat: Connection from 10.129.0.19.
Ncat: Connection from 10.129.0.19:45064.
Ncat: assertion failed: count <= INT_MAX QUITTING.

It uses the nettest image so I suspect this is related to the recent changes in shipyard. Not sure why this only occurs with globalnet enabled.

@skitt @tpantelis
Temporarily disable goheader on pkg/join/options.go
d5a029c 
This triggers a false positive in golangci-lint 1.63.2.

Signed-off-by: Stephen Kitt <[email protected]>
@tpantelis tpantelis mentioned this pull request Jan 6, 2025
Closed
@tpantelis tpantelis closed this Jan 6, 2025
auto-merge was automatically disabled January 6, 2025 16:53

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswinsuryan aswinsuryan Awaiting requested review from aswinsuryan aswinsuryan is a code owner

@dfarrell07 dfarrell07 Awaiting requested review from dfarrell07 dfarrell07 is a code owner

@Jaanki Jaanki Awaiting requested review from Jaanki Jaanki is a code owner

@maayanf24 maayanf24 Awaiting requested review from maayanf24 maayanf24 is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@tpantelis tpantelis Awaiting requested review from tpantelis tpantelis is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

Assignees
No one assigned
Labels
automated e2e-all-k8s ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@submariner-bot @skitt @tpantelis