Use generic resource handling #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
Jaanki,
Oats87,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr966/skitt/generic-resource |
skitt
force-pushed
the
generic-resource
branch
7 times, most recently
from
c823e23 to
6962985
Compare
tpantelis
reviewed
Oct 10, 2023
| @@ -45,8 +44,8 @@ const ( | |||
|
|
|||
| func ensure(ctx context.Context, kubeClient kubernetes.Interface, namespace string, sa *corev1.ServiceAccount) (bool, error) { | |||
| result, err := util.CreateOrUpdate(ctx, resource.ForServiceAccount(kubeClient, namespace), sa, | |||
There was a problem hiding this comment.
Suggested change
| result, err := util.CreateOrUpdate(ctx, resource.ForServiceAccount(kubeClient, namespace), sa, | |
| result, err := util.CreateOrUpdate[*corev1.ServiceAccount](ctx, resource.ForServiceAccount(kubeClient, namespace), sa, |
There was a problem hiding this comment.
I rather like letting the compiler infer the type 😉
There was a problem hiding this comment.
yeah but you've specified the type explicitly in other places so for consistency.... but it doesn't matter either way, that's why I didn't -1 😄
There was a problem hiding this comment.
Ah, I thought I’d dropped the type parameters everywhere they weren’t needed, but I missed some.
skitt
force-pushed
the
generic-resource
branch
from
6962985 to
2f37c7c
Compare
skitt
force-pushed
the
generic-resource
branch
from
2f37c7c to
a990422
Compare
Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
generic-resource
branch
from
a990422 to
f9a6309
Compare
tpantelis
approved these changes
Oct 11, 2023
sridhargaddam
approved these changes
Oct 12, 2023
|
🤖 Closed branches: [z_pr966/skitt/generic-resource] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on submariner-io/admiral#756
Depends on submariner-io/admiral#760
Depends on submariner-io/cloud-prepare#817
Depends on submariner-io/lighthouse#1402
Depends on submariner-io/submariner#2742
Depends on submariner-io/submariner-operator#2839