Mount the Broker secret when available #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
Oats87,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr1712/skitt/mount-broker-secret |
|
This is tested by skitt#24. |
skitt
force-pushed
the
mount-broker-secret
branch
from
4eed5f4 to
41e9a10
Compare
skitt
force-pushed
the
mount-broker-secret
branch
5 times, most recently
from
cef0c04 to
b436318
Compare
dfarrell07
reviewed
Dec 16, 2021
skitt
force-pushed
the
mount-broker-secret
branch
from
b436318 to
7f06471
Compare
skitt
force-pushed
the
mount-broker-secret
branch
from
7f06471 to
1889187
Compare
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
|
Now that Submariner has been updated to use the mounted secrets, skitt#24 passes and this is ready to go. |
dfarrell07
approved these changes
Dec 20, 2021
skitt
force-pushed
the
mount-broker-secret
branch
from
1889187 to
349ddaa
Compare
... and pass its name to the pods which need it. Fixes: submariner-io#1685 Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
mount-broker-secret
branch
from
349ddaa to
a2e0f31
Compare
This was referenced Jan 4, 2022
tpantelis
approved these changes
Jan 4, 2022
|
🤖 Closed branches: [z_pr1712/skitt/mount-broker-secret] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and pass its name to the pods which need it.
Depends on submariner-io/admiral#300
Depends on submariner-io/submariner#1626
Fixes: #1685
Signed-off-by: Stephen Kitt [email protected]