Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to operator-sdk v1.38.0 and kustomize v5 #3298

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

tpantelis
Copy link
Contributor

This mainly involves conforming to the Standard Go Project Layout.

See commits for details.

Fixes #3282

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3298/tpantelis/update_operator_sdk
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

...to conform to the standard Go project layout:
https://github.com/golang-standards/project-layout?tab=readme-ov-file#cmd

Signed-off-by: Tom Pantelis <[email protected]>
- Use sigs.k8s.io/controller-runtime alias for SetupSignalHandler

- Set 'ctx' to the SetupSignalHandler context

- Pass 'cfg' to ctrl.NewManager instead of creating new one

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis tpantelis force-pushed the update_operator_sdk branch 2 times, most recently from 44f749c to ecddcd3 Compare December 9, 2024 19:30
Fixes:

"Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead"

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis tpantelis force-pushed the update_operator_sdk branch from ecddcd3 to 00bf391 Compare December 9, 2024 19:54
@tpantelis tpantelis force-pushed the update_operator_sdk branch from 00bf391 to 8d3cd9a Compare December 9, 2024 22:16
@tpantelis tpantelis enabled auto-merge (rebase) December 10, 2024 22:49
@tpantelis tpantelis added the ready-to-test When a PR is ready for full E2E testing label Dec 10, 2024
@tpantelis tpantelis merged commit e5d27f3 into submariner-io:devel Dec 11, 2024
41 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3298/tpantelis/update_operator_sdk]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Migrate to kubebuilder go/v4 project layout
4 participants