-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to operator-sdk v1.38.0 and kustomize v5 #3298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
mkolesnik,
Oats87,
skitt,
sridhargaddam,
vthapar,
aswinsuryan,
dfarrell07,
maayanf24 and
yboaron
as code owners
December 9, 2024 19:09
🤖 Created branch: z_pr3298/tpantelis/update_operator_sdk |
...to conform to the standard Go project layout: https://github.com/golang-standards/project-layout?tab=readme-ov-file#cmd Signed-off-by: Tom Pantelis <[email protected]>
- Use sigs.k8s.io/controller-runtime alias for SetupSignalHandler - Set 'ctx' to the SetupSignalHandler context - Pass 'cfg' to ctrl.NewManager instead of creating new one Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
update_operator_sdk
branch
2 times, most recently
from
December 9, 2024 19:30
44f749c
to
ecddcd3
Compare
Fixes: "Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead" Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
update_operator_sdk
branch
from
December 9, 2024 19:54
ecddcd3
to
00bf391
Compare
Mainly informational comments. Signed-off-by: Tom Pantelis <[email protected]>
...to conform to the standard Go project layout: https://github.com/golang-standards/project-layout?tab=readme-ov-file#internal Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
update_operator_sdk
branch
from
December 9, 2024 22:16
00bf391
to
8d3cd9a
Compare
skitt
approved these changes
Dec 10, 2024
aswinsuryan
approved these changes
Dec 11, 2024
🤖 Closed branches: [z_pr3298/tpantelis/update_operator_sdk] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly involves conforming to the Standard Go Project Layout.
See commits for details.
Fixes #3282