Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use leader-with-lease based election in the operator #3299

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

tpantelis
Copy link
Contributor

...instead of leader-for-life. The latter was implemented in the operator SDK early on before controller-runtime supported leader-with-lease. However leader-with-lease is the preferred method and leader-for-life is being proposed for deprecation (see operator-framework/operator-lib#117).

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3299/tpantelis/oper_leader_elect
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

...instead of leader-for-life. The latter was implemented in the
operator SDK early on before controller-runtime supported
leader-with-lease. However leader-with-lease is the preferred
method and leader-for-life is being proposed for deprecation
(see operator-framework/operator-lib#117).

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis tpantelis marked this pull request as ready for review December 11, 2024 12:19
@tpantelis tpantelis enabled auto-merge (rebase) December 11, 2024 13:43
@tpantelis tpantelis added the ready-to-test When a PR is ready for full E2E testing label Dec 11, 2024
@tpantelis tpantelis merged commit 5fbba06 into submariner-io:devel Dec 13, 2024
43 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3299/tpantelis/oper_leader_elect]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants