Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated backport of #2708: Fix IPsec whack returning exit status 33 #2711

Conversation

sridhargaddam
Copy link
Member

Backport of #2708 on release-0.16.

#2708: Fix IPsec whack returning exit status 33

For details on the backport process, see the backport requests page.

A recent PR[*] aimed to reduce the downtime of the data path by
initializing the Pluto process during the first connection request,
which is a positive change. However, there was an issue with the API
responsible for starting the Pluto process. It was waiting for a mere
5 seconds and was not handling the timeout properly. Consequently,
attempting to execute any 'whack' commands while the control socket
was absent resulted in an error code of 33 and connections could not
be established.

In one of the OCP deployments, it was observed that it took approximately
25 seconds for the control socket to be created when Pluto was initialized.
This PR addresses the issue by increasing the monitoring interval to
1 minute and also handles timeout scenarios properly.

[*] submariner-io#2543

Signed-off-by: Sridhar Gaddam <[email protected]>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2711/sridhargaddam/automated-backport-of-#2708-origin-release-0.16
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Sep 21, 2023
@skitt skitt enabled auto-merge (rebase) September 21, 2023 11:25
@skitt skitt merged commit ddcd1a9 into submariner-io:release-0.16 Sep 21, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2711/sridhargaddam/automated-backport-of-#2708-origin-release-0.16]

@dfarrell07 dfarrell07 added the release-note-needed Should be mentioned in the release notes label Sep 26, 2023
@dfarrell07
Copy link
Member

This can be release-noted together with the other related IPSec change, #2708.

@sridhargaddam
Copy link
Member Author

Release note PR: submariner-io/submariner-website#1036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-backport ready-to-test When a PR is ready for full E2E testing release-note-handled release-note-needed Should be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants