Automated backport of #2710: Retry IPsec connections when there are any whack errors #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current code, when 'whack' encounters an error, we only log a warning message without hanlding the error case. As a result, in cases where there is an issue connecting to a remote endpoint, the caller is left unaware that connection attempts have failed, and no retries are initiated. This PR fixes it. Signed-off-by: Sridhar Gaddam <[email protected]>
sridhargaddam
requested review from
Oats87,
skitt and
tpantelis
as code owners
|
🤖 Created branch: z_pr2717/sridhargaddam/automated-backport-of-#2710-origin-release-0.14 |
yboaron
approved these changes
Sep 21, 2023
tpantelis
approved these changes
Sep 21, 2023
…2710-origin-release-0.14
|
🤖 Closed branches: [z_pr2717/sridhargaddam/automated-backport-of-#2710-origin-release-0.14] |
dfarrell07
added
the
release-note-needed
|
This can be release-noted together with the other related IPSec change, #2708. |
|
Release note PR: submariner-io/submariner-website#1040 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2710 on release-0.14.
#2710: Retry IPsec connections when there are any whack errors
For details on the backport process, see the backport requests page.