Fixes#3508 #3510
Merged
Fixes#3508 #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -224,7 +224,7 @@ class Blocks { | |||
| } | |||
|
|
|||
| /** Force a refresh. */ | |||
| await delayExecution(500); | |||
| await delayExecution(100); | |||
There was a problem hiding this comment.
Have you taken confirmation with maintainers for this? Because the time for 500ms and 100ms seems quite less and there might be a reason for adding 500ms earlier I believe.
There was a problem hiding this comment.
We made some changes in the rendering logic, so this speed up seems to be OK.
|
Please add #3508 in the PR description going forward and avoid writing the issue ticket number in the commit message. I believe you got a template while raising a PR, don't you? or you removed them? Asking it to identify if contributors are getting PR template or not. |
|
OK ,yes we got template |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reduced the delayExecution time to 100 from 500 which provides much faster UX on rescaling the blocks .