Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVED PLANET NAVBAR #3513

Merged
merged 14 commits into from
Jan 4, 2024
Merged

IMPROVED PLANET NAVBAR #3513

merged 14 commits into from
Jan 4, 2024

Conversation

sivangbagri
Copy link
Contributor

@sivangbagri sivangbagri commented Jan 3, 2024

Continuing PR #3495

This is PR containing changes (sticky navbar and moved search bar)
PR with proper formatting : #3504

@walterbender Kindly Review

planet/index.html Outdated Show resolved Hide resolved
planet/index.html Outdated Show resolved Hide resolved
planet/index.html Outdated Show resolved Hide resolved
@walterbender
Copy link
Member

Thanks for making a new PR w/o the other changes. Please do address the suggestions made by samyakshah.

@theanuragshukla
Copy link

@sivangbagri For PR containing UI changes, It makes sense to add before and after screenshots indicating changes made. It'll help reviewers to make quick suggestions.

@sivangbagri
Copy link
Contributor Author

@walterbender @samyakshah3008 changes made

@walterbender walterbender merged commit 619910c into sugarlabs:master Jan 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants