-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Broadcast Feature #5
Open
IcedTea2K
wants to merge
28
commits into
supabase-community:main
Choose a base branch
from
IcedTea2K:broadcast
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prevent same topic channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
As part 2 of many PRs for #2, this PR implements broadcast functionalities. It should be merged and reviewed AFTER #4. More specifically:
RealtimeChannel.Send()
- a new function to send a broadcast message to the server. It takes in aCustomEvent
struct.RealtimeChannel.Subscribe()
- can now listen to new broadcasted eventsWhat is the current behavior?
Client could only listen to
postgres_changes
right now, without being able to send any message to the server.What is the new behavior?
Client could listen to
broadcast
events as well as send events to the server which will then be broadcasted to all listening clients.Additional context
This is a simple echo client & server. There are two clients and two servers. As seen in the videos, messages sent from any client will be picked up by any server.