Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queues dedup #258

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Queues dedup #258

merged 5 commits into from
Nov 6, 2023

Conversation

ngmachado
Copy link
Collaborator

@ngmachado ngmachado commented Nov 1, 2023 •
edited
Loading

This PR introduce a Queue filter that will remove duplication of estimations accounts.

Additionally also introduce a split on Repository class to support Business Queries and System Queries

@ngmachado ngmachado linked an issue Nov 1, 2023 that may be closed by this pull request
[SENTINEL] Check sender balance only once per block #246
Closed
@ngmachado ngmachado self-assigned this Nov 1, 2023
@ngmachado ngmachado added Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Size: S Type: Enhancement New feature or request labels Nov 1, 2023
@ngmachado ngmachado requested a review from d10r November 1, 2023 16:34
@ngmachado ngmachado added Size: M and removed Size: S labels Nov 1, 2023
d10r
d10r approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@d10r d10r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ngmachado ngmachado merged commit 7a08b7a into master Nov 6, 2023
1 check passed
@ngmachado ngmachado deleted the queues_dedup branch November 6, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d10r d10r d10r approved these changes

Assignees

@ngmachado ngmachado

Labels
Size: M Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SENTINEL] Check sender balance only once per block
2 participants
@ngmachado @d10r