Stabalize the PHP SDK #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Meet the same functionalities of the JS SDK ( ported over ).
- Improved API representation by adding `toString()` to all cbor data classes - Some CBOR data classes having getting additional functionalities reflected based on JS SDK.
- Added escaping of integers
- Improved function documentation - exposed rpc method - added upsert method - compatibility changes for auth methods ( wip )
kearfy
reviewed
Oct 31, 2024
kearfy
approved these changes
Nov 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
To make sure the PHP SDK is up-to-date with all the latest changes of Surreal V2 and that it is stabalized.
What does this change do?
Future,Range,RecordIdRange,BoundIncludedandBoundExcludedtypesrpc,insertRelationandupsertFixed
Breaking
disconnecttoclosein the Surreal ClassSurreal\Cbor\Types\RecordWhat is your testing strategy?
I added unit tests to the PHP SDK for versions
v1.4.2,v1.5.4and2.0.4. Currently we have code coverage of roughly 48% ( rounded down ).Is this related to any issues?
No
Have you read the Contributing Guidelines?