Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version attributes - part 2 #497

Merged
merged 10 commits into from
Nov 21, 2024
Merged

Version attributes - part 2 #497

merged 10 commits into from
Nov 21, 2024

Conversation

jdob
Copy link
Contributor

@jdob jdob commented Nov 20, 2024

Second round of updates. See #495 for more information.

@jdob jdob requested a review from hardys November 20, 2024 21:16
Copy link
Contributor

@hardys hardys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice work figuring out the subs="attributes,specialchars" - I got tripped up on the specialchars part previously when trying to make progress on this.

@jdob jdob merged commit 782271d into suse-edge:main Nov 21, 2024
1 check passed
hardys added a commit to hardys/suse-edge.github.io that referenced this pull request Dec 16, 2024
Follow-up to suse-edge#497 where rancher-docs-version was introduced but
not applied to all existing unversioned links
hardys added a commit to hardys/suse-edge.github.io that referenced this pull request Dec 16, 2024
Follow-up to suse-edge#497 where rancher-docs-version was introduced but
not applied to all existing links
hardys added a commit that referenced this pull request Dec 19, 2024
Follow-up to #497 where rancher-docs-version was introduced but
not applied to all existing links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants