Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(secure-onboarding) Enable acceptance test for Secure cloud account #446

Merged
merged 3 commits into from
Nov 10, 2023
Merged

(secure-onboarding) Enable acceptance test for Secure cloud account #446

merged 3 commits into from
Nov 10, 2023

Conversation

ravinadhruve10
Copy link
Contributor

No description provided.

@ravinadhruve10 ravinadhruve10 marked this pull request as ready for review November 9, 2023 23:39
haresh-suresh
haresh-suresh reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@haresh-suresh haresh-suresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself LGTM, but looks like govet wants you to correctly return a string in case of errors too

if err != nil {
     error := fmt.Errorf(...)
     return error.Error()
}

@ravinadhruve10 ravinadhruve10 merged commit 1bfcf30 into master Nov 10, 2023
23 checks passed
@ravinadhruve10 ravinadhruve10 deleted the secure-onboarding/enable-acc-test branch November 10, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haresh-suresh haresh-suresh haresh-suresh approved these changes

@cgeers cgeers Awaiting requested review from cgeers

@mdkulkarni15 mdkulkarni15 Awaiting requested review from mdkulkarni15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravinadhruve10 @haresh-suresh