Allow JIT compilation for system emulation #521
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vacantron
changed the title
jserv
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: 09fc945 | Previous: 73b1ba5 | Ratio |
|---|---|---|---|
Dhrystone |
1343 Average DMIPS over 10 runs |
1343 Average DMIPS over 10 runs |
1 |
Coremark |
975.239 Average iterations/sec over 10 runs |
979.275 Average iterations/sec over 10 runs |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
jserv
changed the title
jserv
reviewed
Dec 17, 2024
vacantron
force-pushed
the
wip/jit/mmu
branch
from
330a574 to
73b1ba5
Compare
This file is generated by "tools/gen-jit-template.py" To bring up the Linux Kernel to just-in-time (JIT) compilation, we need to update the memory-related operation with the memory management unit. However, the current "src/rv32_jit.c" was generated by the template. That template reduced the rework for the repeated statements, but also reduced the flexibility and the intuitiveness for bring up the new feature. In this commit, we deprecate that template and just use a regular file for the flexibility.
This commit introduces "satp" field to the block structure in JIT mode to ensure the block cache is replaced correctly. The MOP fusion and T2C are disabled temporarily. Use the following commands to boot Linux Kernel: $ make ENABLE_SYSTEM=1 ENABLE_MOP_FUSION=0 ENABLE_JIT=1 ENABLE_T2C=0 $ ./build/rv32emu -k <image> -i <rootfs> -b <dtb>
vacantron
force-pushed
the
wip/jit/mmu
branch
from
73b1ba5 to
09fc945
Compare
jserv
reviewed
Dec 18, 2024
Comment on lines
+845
to
+848
| #if RV32_HAS(SYSTEM) | ||
| if (next_blk && next_blk->satp != rv->csr_satp) | ||
| next_blk = NULL; | ||
| #endif |
jserv
reviewed
Dec 18, 2024
Comment on lines
+926
to
+933
| #if 0 | ||
| /* | ||
| * This branch lookup updating is unused since we get the PC from it and | ||
| * use function "cache_get()" achieve the branch prediction of T1C. | ||
| * However, if the structure "branch_table_t" is going to reference the | ||
| * block directly, this updating is nacessary to avoid to use the freed | ||
| * blocks. | ||
| */ |
There was a problem hiding this comment.
I didn't get it. When is it safe to release the resources?
There was a problem hiding this comment.
As the comments above, the current workflow is safe. However, if the implementation of branch_table is changed (e.g. storing the possible blocks directly instead of the program counters), this updating cannot be ignored.
jserv
reviewed
Dec 18, 2024
| @@ -126,6 +129,18 @@ struct riscv_internal { | |||
| riscv_word_t X[N_RV_REGS]; | |||
| riscv_word_t PC; | |||
|
|
|||
| #if RV32_HAS(JIT) && RV32_HAS(SYSTEM) | |||
| /* | |||
| * Aarch encoder only accepts 9 bits signed offset. Do not put this | |||
jserv
reviewed
Dec 18, 2024
Comment on lines
+138
to
+139
| uint32_t is_mmio; /* whether is MMIO or not */ | ||
| uint32_t type; /* 0: read, 1: write */ |
There was a problem hiding this comment.
Would you use bit-fields instead?
There was a problem hiding this comment.
To simplify the emission of load/store instructions of both x86-64 and Aarch64 in src/rv32_jit.c, I would like to keep them as unsigned integer.
ChinYikMing
reviewed
Dec 18, 2024
| @@ -704,6 +706,7 @@ static inline void remove_next_nth_ir(const riscv_t *rv, | |||
| * Strategies are being devised to increase the number of instructions that | |||
| * match the pattern, including possible instruction reordering. | |||
| */ | |||
| #if RV32_HAS(MOP_FUSION) | |||
There was a problem hiding this comment.
Wrap around the comment as well.
Testing Report:x86-64 machine: Kernel message Logs: Aarch64 machine: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes
rv32emusupport the just-in-time (JIT) compilation in system simulation. To achieve this goal, a "satp (supervisor address translation and protection)" field has been introduced to the block structure in JIT mode to ensure the block cache is replaced correctly.The file
src/system.chas been updated for the easier reuse of functions, and the MOP fusion and T2C are disabled temporarily. To boot the Linux Kernel, try the following commands: