Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall: fix uninstalling if no symlink in bin_dir #997

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Japsty
Copy link
Contributor

@Japsty Japsty commented Oct 31, 2024

tt uninstall does not work if there is no symbolic link in bin_dir, so a check for the presence of a symbolic link has been added.

Closes: 900

Copy link
Collaborator

@psergee psergee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

cli/uninstall/uninstall.go Outdated Show resolved Hide resolved
cli/uninstall/uninstall.go Outdated Show resolved Hide resolved
cli/uninstall/uninstall.go Outdated Show resolved Hide resolved
cli/uninstall/uninstall.go Show resolved Hide resolved
@Japsty Japsty force-pushed the dvinogradov/gh-900-uninstall-doesnt-work-if-no-symlink branch 2 times, most recently from e5f0c84 to 713650d Compare November 1, 2024 12:07
@Japsty Japsty requested a review from psergee November 5, 2024 08:54
@Japsty Japsty force-pushed the dvinogradov/gh-900-uninstall-doesnt-work-if-no-symlink branch 2 times, most recently from a25a070 to b607ea1 Compare November 14, 2024 10:33
tt uninstall does not work if there is no symbolic link in bin_dir,
so a check for the presence of a symbolic link has been added.

Closes: [900](tarantool#900)
@Japsty Japsty force-pushed the dvinogradov/gh-900-uninstall-doesnt-work-if-no-symlink branch from b607ea1 to 335fe45 Compare November 14, 2024 10:34
Copy link
Collaborator

@psergee psergee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@psergee psergee added the full-ci Enables full ci tests label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tt uninstall does not work if no symlink in bin_dir
2 participants