Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ta-1105): add bundling options to authenticated api #89

Merged
merged 2 commits into from
Jul 18, 2024
Merged

feat(ta-1105): add bundling options to authenticated api #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6d007c
feat(ta-1105): add bundling options to authenticated api
mike-dean-talis Jul 18, 2024
91abf12
feat(ta-1105): add bundling options to authenticated api
mike-dean-talis Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/authenticated-api/authenticated-api-function-props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as cdk from "aws-cdk-lib";
import { aws_ec2 as ec2 } from "aws-cdk-lib";
import { BundlingOptions } from "aws-cdk-lib/aws-lambda-nodejs";

export interface AuthenticatedApiFunctionProps {
name: string;
Expand All @@ -11,4 +12,5 @@ export interface AuthenticatedApiFunctionProps {
vpcSubnets?: ec2.SubnetSelection;
securityGroups?: Array<ec2.ISecurityGroup>;
memorySize?: number;
bundling?: BundlingOptions;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this type correct? I've just had a quick look at the docs and was expecting to see something related to externalModules & nodeModules.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: Good catch. I had imported the wrong thing.

}
1 change: 1 addition & 0 deletions lib/authenticated-api/authenticated-api-function.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export class AuthenticatedApiFunction extends lambdaNode.NodejsFunction {
securityGroups: props.securityGroups,
vpc: props.vpc,
vpcSubnets: props.vpcSubnets,
bundling: props.bundling,
});
}
}
Loading