feat: move away from opentelemetry #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current setup with OpenTelemetry sucks because no data is being emitted anywhere. So I think it'd be best if we revert all that and just use plain Sentry with their built-in performance integration.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| name: "closed", | ||
| op: "presentation.event-handlers.PullRequest" | ||
| }, () => { | ||
| let template = this._templates.closed.base; |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 25.76% 25.91% +0.14%
==========================================
Files 47 46 -1
Lines 2278 2327 +49
Branches 92 91 -1
==========================================
+ Hits 587 603 +16
- Misses 1659 1693 +34
+ Partials 32 31 -1 ☔ View full report in Codecov by Sentry. |
elianiva
approved these changes
Mar 30, 2024
krowter
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup with OpenTelemetry sucks because no data is being emitted anywhere. So I think it'd be best if we revert all that and just use plain Sentry with their built-in performance integration.