Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rce): support ocaml 2.1.5 #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(rce): support ocaml 2.1.5 #162

wants to merge 1 commit into from

Conversation

ii64
Copy link
Contributor

@ii64 ii64 commented Feb 2, 2024

No description provided.

@ii64 ii64 requested review from aldy505 and elianiva as code owners February 2, 2024 21:08
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd35aa0) 81.17% compared to head (9e5ac13) 81.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   81.17%   81.17%           
=======================================
  Files          34       34           
  Lines        1535     1535           
  Branches      140      140           
=======================================
  Hits         1246     1246           
  Misses        223      223           
  Partials       66       66           
Flag Coverage Δ
auth 41.31% <ø> (ø)
rce 90.45% <ø> (ø)
sdk-dotnet 87.74% <ø> (ø)
sdk-go 66.48% <ø> (ø)
sdk-javascript 88.69% <ø> (ø)
sdk-python 99.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ii64 ii64 force-pushed the feature/support-ocaml branch from 2a58491 to b870aae Compare February 2, 2024 21:14
@ii64 ii64 changed the title feat: support ocaml 2.1.5 feat(rce): support ocaml 2.1.5 Feb 2, 2024
Copy link
Member

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an error on the CI

#7 5175.3 Installing ocaml.
#7 5175.3 ## Downloading opam 2.1.5 for linux on x86_64...
#7 5175.3 
#7 5175.3 ## Downloaded.
#7 5175.3 
#7 5175.3 ## Where should it be installed ? [/usr/local/bin] 
#7 5175.3 ## Backing up /opt/ocaml/2.1.5 to 2.1.5. (this may take a while)
#7 5175.3 
#7 5175.3 ## /opt/ocaml/2.1.5 backed up as 2.1.5.
#7 5175.3 
#7 5175.3 ## opam 2.1.5 installed to /opt/ocaml/2.1.5
#7 5175.3 
#7 5175.3 ## Converting the opam root format & updating
#7 5175.3 
#7 5175.3 No configuration file found, using built-in defaults.
#7 5175.3 Proceed? [Y/n] n

It seems like the installation requires confirmation, yet we're running the container with DEBIAN_FRONTEND=noninteractive. You might wanna customize your installation, or... try to build from source.

@ii64 ii64 force-pushed the feature/support-ocaml branch from b870aae to 9e5ac13 Compare February 3, 2024 14:34
@aldy505
Copy link
Member

aldy505 commented Feb 7, 2024

Your CI is still broken

#7 5148.3 Installing ocaml.
#7 5148.3 PWD: /opt/ocaml/2.1.5
#7 5148.3 Bootstrapping opam
#7 5148.3 
#7 5148.3 ## Downloading opam 2.1.5 for linux on x86_64...
#7 5148.3 
#7 5148.3 ## Downloaded.
#7 5148.3 
#7 5148.3 ## Where should it be installed ? [/usr/local/bin] 
#7 5148.3 ## Backing up /opt/ocaml/2.1.5 to 2.1.5. (this may take a while)
#7 5148.3 
#7 5148.3 ## /opt/ocaml/2.1.5 backed up as 2.1.5.
#7 5148.3 
#7 5148.3 ## opam 2.1.5 installed to /opt/ocaml/2.1.5
#7 5148.3 
#7 5148.3 ## Converting the opam root format & updating
#7 5148.3 
#7 5148.3 No configuration file found, using built-in defaults.
#7 5148.3 
#7 5148.3 Proceed? [Y/n] n
#7 5148.3 
#7 ERROR: process "/bin/sh -c apt-get update &&   apt-get upgrade -y &&   apt-get install -y coreutils binutils build-essential libseccomp-dev gcc     apt-utils curl tar bzip2 gzip make cmake zip unzip autoconf pkg-config     flex perl sed clang libc6-dev libc6 &&   make -C ./nosocket/ all && make -C ./nosocket/ install &&   npm ci &&   node ./scripts/install.cjs &&   apt-get remove -y bzip2 make cmake zip unzip flex clang gcc g++ apt-utils     build-essential &&   node ./scripts/register-users.cjs &&   npm run build &&   rm -rf node_modules && npm ci --omit=dev &&   apt-get autoremove -y && apt-get clean -y &&   rm -rf /var/lib/apt/lists/*" did not complete successfully: exit code: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants