Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Tags and Blade Namespaced Components #156

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Conversation

tonysm
Copy link
Contributor

@tonysm tonysm commented Oct 20, 2024

Changed

  • Fixes matching Blade's namespaced components

Added

  • Adds the PHP tags as keywords.

PHP Tags before/after

Before:
image

After:
image


Short Tags:

Before:
image

After:
image

Blade Components before/after

Before:
image

After:
image

I have made everything keyword, but not sure if anything else would better describe it. Let me know if y'all think something else would be more adequate.

@brendt brendt merged commit 2d119af into tempestphp:main Oct 20, 2024
4 checks passed
@brendt
Copy link
Member

brendt commented Oct 20, 2024

Thanks! Looks good :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11423415589

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 92.84%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Languages/Blade/Patterns/BladeComponentCloseTagPattern.php 1 2 50.0%
src/Languages/Blade/Patterns/BladeComponentOpenTagPattern.php 1 2 50.0%
src/Languages/Php/Patterns/PhpCloseTagPattern.php 1 2 50.0%
src/Languages/Php/Patterns/PhpOpenTagPattern.php 1 2 50.0%
Totals Coverage Status
Change from base Build 11402805639: -0.2%
Covered Lines: 1569
Relevant Lines: 1690

💛 - Coveralls

@brendt
Copy link
Member

brendt commented Oct 20, 2024

Tagged: https://github.com/tempestphp/highlight/releases/tag/2.10.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants