feat(console): add make:view command
#864
Conversation
|
|
||
| private function getStubFileFromViewType(ViewType $viewType): StubFile | ||
| { | ||
| try { |
There was a problem hiding this comment.
I don't think it's necessary to throw an exception type, and re-throw another type after. Can you just return the match result?
I'm also curious about that "guardrail", wouldn't phpstan always catch it if we added a new ViewType? We don't need to throw here, right?
There was a problem hiding this comment.
This is because StubFile can also throw an InvalidArgumentException so we catch this to throw a more specific exception.
For the "guardrail", you're right, phpstan will catch it until we change the config ( I don't think this should happen )
But, it's more a personal preference to have a more specific error message instead of a generic phpstan error.
I can remove it on make commands where I've implemented that if you prefer ?
Co-authored-by: Enzo Innocenzi <[email protected]>
Co-authored-by: Enzo Innocenzi <[email protected]>
This PR adds the
make:viewcommandThis PR check a TODO on #759
I'm not familiar with the view system in Tempest so I need detailed review on stubs and supported generated classes.
That being said, I currently support the creation of a basic view file like this :
make:view home=> this will ask forhome.view.phppath and then creates an empty php filemake:view HomeView class=> this second enum parameter will specify that we want to create the view class documented here https://tempestphp.com/docs/framework/views/#view-objectsI don't know if more view class are needed for this command, but I think this is something that can be added when needed 😄