Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new features/refactoring #10

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

new features/refactoring #10

wants to merge 53 commits into from

Conversation

rbndg
Copy link
Contributor

@rbndg rbndg commented Nov 20, 2024

Fixed/Refactor:

  • Removed all inline imports
  • Fixed node.js / AI example apps
  • Moved some classes like state and others into their own files
  • ws-bare: This module needed keep alive logic implemented as its not supported by bare's ws module.

New Features:

  • TxEntry Class: The format for returning data from doing a new transaction or fetching tx history from any asset
  • PluginBase Class: Base class that has some methods that allows a plugin's methods to be exposed to the outside.
    • Updated Wallet Pay needed changes for this
  • ConnectionManager: Base Class to be extended by blockchain data providers that handles connection states and reconnection logic
    • The base class Provider has been updated to to use ConnectionManager
  • WalletPay Module Info: _getModuleInfo, retrieves version and name of the asset. This is used by the wallet importing logic in the app to determine comparability of an exported wallet.
  • WalletManager: A module for applications that will need multiple instances of lib-wallet. Handles logic of loading wallet, importing. This is used by lib-wallet-bare.
  • New tests for some of these new features

@rbndg rbndg changed the title Feat: import and export wallet new features: export wallet, TxEntry, Plugin system Jan 7, 2025
@@ -0,0 +1,328 @@
'use strict'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unchanged from one in master

@rbndg rbndg changed the title new features: export wallet, TxEntry, Plugin system new features/refactoring Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants