Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new Boiler Strain: Sizzler #16843

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

blackdav123
Copy link
Contributor

@blackdav123 blackdav123 commented Dec 24, 2024

About The Pull Request

Adds a new boiler strain: Sizzler

Trading long range suppression for mid range disruption, the Sizzler is meant to divide and isolate marines to help its team get better fights.

Same stats as regular boiler, you will still need to be supported by your team.

Changes since first testmerge:

  • Spit speed is now 0.5, same as spitter.

Abilities

  • Airburst Spit:

    • 15 damage
    • 70 plasma
    • splits into three 10 damage projectiles that pass through enemies and leave a transparent acid cloud.
  • Smokescreen Spit:

    • 35 damage
    • 700 plasma
    • 2 stagger
    • 3 slowdown
    • splits into five 0 damage projectiles that leave a wall of smoke behind the target.
    • locks the sizzler out of spitting for 18 seconds
  • Steam Rush:

    • 100 plasma
    • 25 second cooldown
    • gives a buff for 1.5 seconds that increases speed by -1 and makes slashes deal 10 extra burn damage and reset the timer.
  • Acid Spray:

    • Same as boiler
  • Primordial: High Pressure Spit

    • 50 damage
    • 150 plasma
    • 25 second cooldown
    • fires a single shot that knocks back that stuns, staggers, slows, and knocks back the target 7 tiles
    • applies 10 seconds of shatter to the target
Videos
Airburst-spit.mp4
steam-rush.mp4
steam-rush-long.mp4
Smokescreen-spit.mp4
primo-spit.mp4
primo-combo.mp4

To do

  • Add a primo
  • Balance it

Why It's Good For The Game

Variety, xeno content, and gives xenos a t3 that is better at dividing a marine ball.

Changelog

🆑
add: Added Sizzler boiler strain
/:cl:

@tgstation-server tgstation-server added Sprites Changes to .dmi file. Feature New interesting mechanics with new interesting bugs labels Dec 24, 2024
@despong
Copy link

despong commented Dec 24, 2024

cqc boiler is real

@Clay500z
Copy link
Contributor

Sprite looks terrible but you're cooking

@tttruancy
Copy link

tttruancy commented Dec 24, 2024

Seems fun I like it, maybe lower the airburst spit projectile speed to make it look a little less crazy

@Aporhtonoma
Copy link
Contributor

THE UGL BOILER IS REAL MERGE PLEASE

@iforgotmeword
Copy link

is there a way to swap spit types? or are you stuck with acid?

(awful primo idea: root wind-up but makes Airburst Spit rapid fire)

added_spit_delay = 14 SECONDS
spit_cost = 500
damage = 35
stagger_stacks = 2
Copy link
Contributor

@Runian Runian Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt stagger_stacks be in seconds? /datum/ammo/xeno/toxin has it in seconds

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@Technical-l
Copy link
Contributor

Sprite looks terrible but you're cooking

image
the boiler

Copy link
Member

@TiviPlus TiviPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok from a gander @Kuro020 review walance

add_cooldown()

/datum/action/ability/activable/xeno/high_pressure_spit/on_cooldown_finish() //Give high pressure spit a proper cooldown notification
to_chat(owner, span_xenodanger("Our steam is welling up; we can use high pressure spit again."))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use balloon alert pls

succeed_activate()
add_cooldown()

/datum/action/ability/activable/xeno/high_pressure_spit/on_cooldown_finish() //Give high pressure spit a proper cooldown notification
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/datum/action/ability/activable/xeno/high_pressure_spit/on_cooldown_finish() //Give high pressure spit a proper cooldown notification
/datum/action/ability/activable/xeno/high_pressure_spit/on_cooldown_finish()

comment is pointless


var/datum/ammo/xeno/acid/heavy/high_pressure_spit/high_pressure_spit = GLOB.ammo_list[/datum/ammo/xeno/acid/heavy/high_pressure_spit]

var/obj/projectile/newspit = new /obj/projectile(get_turf(X))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var/obj/projectile/newspit = new /obj/projectile(get_turf(X))
var/obj/projectile/newspit = new(get_turf(X))

Comment on lines 508 to 509
//Shoot at the thing
playsound(X.loc, 'sound/voice/alien/hiss2.ogg', 50, 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//Shoot at the thing
playsound(X.loc, 'sound/voice/alien/hiss2.ogg', 50, 1)
playsound(X.loc, 'sound/voice/alien/hiss2.ogg', 50, 1)

Comment on lines 457 to 459
X.remove_movespeed_modifier(MOVESPEED_ID_BOILER_SIZZLER_STEAM_RUSH) //Reset speed

X.playsound_local(X, 'sound/voice/alien/hiss2.ogg', 50) //Audio cue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
X.remove_movespeed_modifier(MOVESPEED_ID_BOILER_SIZZLER_STEAM_RUSH) //Reset speed
X.playsound_local(X, 'sound/voice/alien/hiss2.ogg', 50) //Audio cue
X.remove_movespeed_modifier(MOVESPEED_ID_BOILER_SIZZLER_STEAM_RUSH)
X.playsound_local(X, 'sound/voice/alien/hiss2.ogg', 50)

Comment on lines 466 to 467
to_chat(owner, span_xenodanger("Our blood is boiling once more; we can use steam rush again."))
owner.playsound_local(owner, 'sound/effects/alien/new_larva.ogg', 25, 0, 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ballon alert pls

Comment on lines 447 to 448
if(steam_rush_ability.steam_rush_duration) //Check if steam rush is active
deltimer(steam_rush_ability.steam_rush_duration) //Reset timers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(steam_rush_ability.steam_rush_duration) //Check if steam rush is active
deltimer(steam_rush_ability.steam_rush_duration) //Reset timers
if(steam_rush_ability.steam_rush_duration)
deltimer(steam_rush_ability.steam_rush_duration)

Comment on lines 318 to 319
///How many
var/bonus_projectile_quantity = 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coder was shot dead while writing documentation, this is so sad 💔

Comment on lines 386 to 387
target_carbon.adjust_stagger(stagger_stacks) //stagger briefly; useful for support
target_carbon.add_slowdown(slowdown_stacks) //slow em down
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
target_carbon.adjust_stagger(stagger_stacks) //stagger briefly; useful for support
target_carbon.add_slowdown(slowdown_stacks) //slow em down
target_carbon.adjust_stagger(stagger_stacks)
target_carbon.add_slowdown(slowdown_stacks)

var/shatter_duration = 10 SECONDS

/datum/ammo/xeno/acid/heavy/high_pressure_spit/on_hit_mob(mob/target_mob, obj/projectile/proj)
if(iscarbon(target_mob))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

early return here pls

@blackdav123 blackdav123 requested a review from TiviPlus December 27, 2024 00:40
@PibeCantina
Copy link
Contributor

The rizzler

@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label Dec 30, 2024
@tgstation-server tgstation-server removed the Merge Conflict Pull request is in a conflicted state with base branch. label Dec 31, 2024
@Kuro020 Kuro020 added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Dec 31, 2024
comfyorange added a commit that referenced this pull request Dec 31, 2024
comfyorange added a commit that referenced this pull request Dec 31, 2024
comfyorange added a commit that referenced this pull request Dec 31, 2024
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jan 1, 2025
@Kuro020 Kuro020 added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jan 1, 2025
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jan 1, 2025
comfyorange added a commit that referenced this pull request Jan 1, 2025
comfyorange added a commit that referenced this pull request Jan 1, 2025
@despong
Copy link

despong commented Jan 2, 2025

  1. Changing from glob to spittle requires you to have enough plasma to fire again plasma (fucking annoying when i want to swap to spittle after using glob)
  2. Steam glob timer doesn't carry over when you swap to spittle.
  3. Wish the acid glob was like 1-2 tiles bigger? Weird to use when you spit diagonal and it leads pockets in your gas cloud
  4. No balloon for spittle when you want to sprit and you're out of acid (i think)

@Looking4bros
Copy link

The smokescreen spit is very nice in it's effect, striking broad instead of one big glob, as it in some instances will permitting the marine to take a few steps towards the xenos, instead of being required to pull out entirely. I find it a very neat ability.

comfyorange added a commit that referenced this pull request Jan 2, 2025
@Cpol-CzHa Cpol-CzHa mentioned this pull request Jan 2, 2025
comfyorange added a commit that referenced this pull request Jan 2, 2025
comfyorange added a commit that referenced this pull request Jan 7, 2025
comfyorange added a commit that referenced this pull request Jan 7, 2025
comfyorange added a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Sprites Changes to .dmi file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.