Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. As a user, I want to be able to sign in to the app. #16

Merged
merged 4 commits into from
Feb 4, 2024

Conversation

raaynaldo
Copy link
Collaborator

Description

  • Add sign in button and add signout button.
  • set up the firebase config.

Related Issue

closes #1

Acceptance Criteria

  • The useAuth hook as well as the SignInButton and SignOutButton components are imported into Layout.jsx.
  • The SignInButton is displayed on every page if the user is not signed in.
  • The SignOutButton is displayed on every page if the user is signed in.

Type of Changes

new feature

Updates

  • add useAuth, SignInButton, SignOutButton component to the Layout.jsx
  • Update the config.js

Before

CleanShot 2024-02-04 at 11 31 08

After

CleanShot 2024-02-04 at 11 31 32

Testing Steps / QA Criteria

  • try to sign in and sign out.

@raaynaldo raaynaldo requested a review from cafloyd February 4, 2024 16:32
Copy link

github-actions bot commented Feb 4, 2024

Visit the preview URL for this PR (updated for commit 6ce66e9):

https://tcl-68-smart-shopping-list--pr16-rs-la-sign-in-3obzsf7h.web.app

(expires Sun, 11 Feb 2024 16:42:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8cb5d089a99ba9972009993f4dd31796b0cbda84

Copy link
Member

@cafloyd cafloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @luisaugusto and @raaynaldo just one question for you before I approve.

src/views/Layout.jsx Outdated Show resolved Hide resolved
src/views/Layout.jsx Outdated Show resolved Hide resolved
Co-authored-by: Luis Augusto <[email protected]>
Copy link
Member

@cafloyd cafloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!

@raaynaldo raaynaldo merged commit 061c015 into main Feb 4, 2024
2 checks passed
@raaynaldo raaynaldo deleted the rs-la-sign-in branch February 4, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1. As a user, I want to be able to sign in to the app.
3 participants