Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm about page final #67

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Sm about page final #67

merged 10 commits into from
Apr 11, 2024

Conversation

sdmisra
Copy link
Collaborator

@sdmisra sdmisra commented Apr 10, 2024

Description

This PR adds an about page and button, enabling a user to learn more about our application, its creators, and the Collab Lab.

Related Issue

None yet listed - this is a post MVP addition inspired by other TCL projects that were demo'd on April 7th, 2024.

Acceptance Criteria

[x] As a user, I'd like to be able to learn about features of the application that are not immediately clear
[x] As a user, I'd like to be able to inquire about the creators and process of building this application

Type of Changes

feature
view

Updates

Before

Screenshot 2024-04-10 at 10 46 20 AM

After

Screenshot 2024-04-10 at 10 48 22 AM Screenshot 2024-04-10 at 10 49 06 AM Screenshot 2024-04-10 at 10 49 37 AM

Testing Steps / QA Criteria

  1. navigate to branch sm-about-page-final or PR deployment below
  2. confirm '?' button appears on home page
  3. sign in, navigate to multiple other views, confirm button remains in header
  4. click button to browse about page
  5. confirm links to Linkedin as well as The Collab Lab work, and open in new browser window when clicked

Copy link

github-actions bot commented Apr 10, 2024

Visit the preview URL for this PR (updated for commit be6e707):

https://tcl-68-smart-shopping-list--pr67-sm-about-page-final-tl6uz0w1.web.app

(expires Thu, 18 Apr 2024 05:08:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8cb5d089a99ba9972009993f4dd31796b0cbda84

@sdmisra sdmisra requested a review from andiedoescode April 10, 2024 16:57
Copy link
Collaborator

@andiedoescode andiedoescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay we're almost there! Nice work summarizing the main functionality of our app.

src/views/About.jsx Outdated Show resolved Hide resolved
src/views/About.jsx Show resolved Hide resolved
src/views/Layout.jsx Outdated Show resolved Hide resolved
src/components/AboutButton.jsx Show resolved Hide resolved
@andiedoescode andiedoescode merged commit c89ec44 into main Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants