Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have fixed chip width, update calculateUrgency function #56

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Conversation

g-lee2
Copy link
Collaborator

@g-lee2 g-lee2 commented Apr 1, 2024

Description

-Add width to chips
-Fix calculateUrgency so it includes cases that don't have daysUntilNextPurchase or have not been purchased yet

Related Issue

closes #49

Acceptance Criteria

  • Fix width of Item Chips to be a consistent size
  • Fix calculateUrgency so it includes cases that don't have daysUntilNextPurchase or have not been purchased yet

Type of Changes

Type
✨ Enhancements
✨ Bug Fix

Updates

Before

Screenshot 2024-03-31 at 9 13 08 PM Screenshot 2024-03-31 at 9 12 58 PM

After

Screenshot 2024-03-31 at 9 21 48 PM Screenshot 2024-03-31 at 9 21 55 PM

Testing Steps / QA Criteria

  • From your terminal, pull down this branch with git pull origin gl-designand check that branch out with git checkout gl-design
  • Run npm start in your terminal
  • Click on any shopping list, and view changes to chips

Copy link

github-actions bot commented Apr 1, 2024

Visit the preview URL for this PR (updated for commit fe55ee1):

https://tcl-70-smart-shopping-list--pr56-gl-design-9dw9rb8t.web.app

(expires Mon, 08 Apr 2024 04:29:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7bb526f3a6607712c7f73ffd6c0dfff4c62b86d9

@g-lee2 g-lee2 changed the title Gl design Have fixed chip width, update calculateUrgency function Apr 1, 2024
@g-lee2 g-lee2 merged commit 312fa1b into main Apr 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

21. FIX MINOR ISSUES WITH CHIPS
1 participant