Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NavBar Link, Adjust List Page Design #62

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Conversation

g-lee2
Copy link
Collaborator

@g-lee2 g-lee2 commented Apr 2, 2024

Description

Made changes to the Navbar by adding margin bottom, changing Navbar link color, changing Manage List to about, and making sure to change all routes from manage-list to about. There were changes made with the .Layout-main and .Layout in the Layout.css so that the content fills up more space. Made a few fixes the content in Accordion component to be more responsive. Additionally in the List page, added border and border radius to item cards (and the delete button) and other related issues regarding responsiveness.

Related Issue

closes #61

Acceptance Criteria

  • Change Manage List to about in Navbar
  • Make sure to change all routes from manage-list to about.
  • Navbar needs margin bottom so it doesn't cover the content below.
  • The links on the Navbar need to be changed to the page's beige theme color.
  • The .Layout-main and .Layout in the Layout.css needs to be fixed so that the content fills up more space.
  • Fix the content in Accordion component to be more responsive.
  • Add border and border radius to item cards.
  • Overall, fix minor design related issues regarding responsiveness.

Type of Changes

Type
✨ Enhancements

Updates

Before

Screenshot 2024-04-02 at 8 48 59 AM Screenshot 2024-04-02 at 8 49 15 AM

After

Screenshot 2024-04-02 at 8 38 42 AM Screenshot 2024-04-02 at 8 38 24 AM

Testing Steps / QA Criteria

  • From your terminal, pull down this branch with git pull origin gl-navbar-list-page-fix and check that branch out with git checkout gl-navbar-list-page-fix
  • Run npm start in your terminal
  • Click on any shopping list, and view changes to Navbar and List page (adjust screen size/mobile to view all changes)

Copy link

github-actions bot commented Apr 2, 2024

Visit the preview URL for this PR (updated for commit aba5f9b):

https://tcl-70-smart-shopping-list--pr62-gl-navbar-list-page-bkzocu35.web.app

(expires Tue, 09 Apr 2024 16:00:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7bb526f3a6607712c7f73ffd6c0dfff4c62b86d9

Copy link
Collaborator

@MiliMade MiliMade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💃

Copy link
Collaborator

@chungleee chungleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noiceeee

@g-lee2 g-lee2 self-assigned this Apr 2, 2024
@g-lee2 g-lee2 merged commit cf63545 into main Apr 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

27. Fix NavBar Link, Adjust List Page Design
3 participants