Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed delete and edit icons from card and added functionality to show owner of shared card #63

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

MiliMade
Copy link
Collaborator

@MiliMade MiliMade commented Apr 2, 2024

Description

This code adds a function that searches the firestore database for user details using a users id. The id for each card is taken from the path string. If the user id does not match the current user id (id of the user signed in) then the card show's the name of the owner of the list.
Both the delete and edit icons were also removed.

Related Issue

closes #58

Acceptance Criteria

  • The delete and edit icons should be removed and replaced by a button that has the share icon and the text "Share this list"
  • The share button should be fully functional
  • On shared lists, there should be text that tells the user that is shared. If possible it should tell the user who shared the list with them (e.g. "Shared by {name of user})

Type of Changes

Type
✨ Enhancements

Updates

Before

image

After

image

Testing Steps / QA Criteria

  • From your terminal, pull down this branch with git pull origin km-list-icons and check that branch out with git checkout km-list-icons
  • In your browser, go to http://localhost:3000/
  • Sign in to view changes to the list cards on the home page
  • Test the functionality of the share button on cards

Copy link

github-actions bot commented Apr 2, 2024

Visit the preview URL for this PR (updated for commit cb0fe2d):

https://tcl-70-smart-shopping-list--pr63-km-list-icons-ryd8xaia.web.app

(expires Wed, 10 Apr 2024 20:11:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7bb526f3a6607712c7f73ffd6c0dfff4c62b86d9

Copy link
Collaborator

@chungleee chungleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@MiliMade MiliMade merged commit b1aab15 into main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

25. Remove unused icons from card and add text to shared list cards to tell user that it's a shared list
4 participants